Skip to content

docs: update incremental benchmarks (3.9.6)#1032

Merged
carlos-alm merged 4 commits intomainfrom
benchmark/incremental-v3.9.6-20260430-065206
May 1, 2026
Merged

docs: update incremental benchmarks (3.9.6)#1032
carlos-alm merged 4 commits intomainfrom
benchmark/incremental-v3.9.6-20260430-065206

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Automated incremental benchmark update for 3.9.6 from workflow run #786.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 30, 2026

Greptile Summary

This automated PR appends 3.9.6 incremental benchmark results (native and WASM build, no-op rebuild, 1-file rebuild, and import-resolution metrics) to the summary table and latest-results section. It also drops the <!-- NOTES_START --> / <!-- NOTES_END --> block that explained the 3.9.5 null-build situation — both of those issues (#1042, #1043) are already tracked from a prior review cycle and are not re-raised here.

Confidence Score: 5/5

Safe to merge — documentation-only change with internally consistent data

No P0 or P1 issues found. The JSON payload, rendered tables, and latest-results section are mutually consistent. Previously identified concerns (missing 3.9.5 explanation, unannotated WASM regressions) are already tracked as follow-up issues and are not re-flagged here.

No files require special attention

Important Files Changed

Filename Overview
generated/benchmarks/INCREMENTAL-BENCHMARKS.md Adds 3.9.6 benchmark data (native + WASM build/rebuild/resolve metrics) and removes the 3.9.5 notes block; JSON payload and rendered tables are internally consistent

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    WF["GitHub Actions\nWorkflow #786"] --> |"benchmark run"| RAW["Raw timing data\n(native + WASM engines)"]
    RAW --> GEN["update-incremental-report.ts\n(generator script)"]
    GEN --> JSON["Embedded JSON block\n(INCREMENTAL_BENCHMARK_DATA)"]
    GEN --> TABLE["Summary table\n(top-level version history)"]
    GEN --> LATEST["Latest results section\n(per-metric breakdown + phases)"]
    JSON --> MD["INCREMENTAL-BENCHMARKS.md"]
    TABLE --> MD
    LATEST --> MD
    MD --> |"PR #1032"| MAIN["main branch"]
Loading

Reviews (3): Last reviewed commit: "Merge branch 'main' into benchmark/incre..." | Re-trigger Greptile

Comment on lines 57 to +60

### Latest results

**Version:** 3.9.5 | **Files:** 742 | **Date:** 2026-04-23
**Version:** 3.9.6 | **Files:** 744 | **Date:** 2026-04-30
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 3.9.5 absence no longer explained after note removal

The <!-- NOTES_START --> block that explained why 3.9.5 is absent from the top-level summary table was deleted, but 3.9.5 still has no row in that table (its JSON entry retains "wasm": null, "native": null). Anyone reading the table after this PR will see the history jump from 3.9.4 straight to 3.9.6 with no explanation. The note could either be kept as-is or condensed to a brief parenthetical on the 3.9.5 JSON entry.

Fix in Claude Code

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked as a generator bug rather than a fix-in-place on this auto-generated file: #1042. The note that PR #1008 added was a manual edit, but scripts/update-incremental-report.ts regenerates the file from scratch on every release and has no awareness of <!-- NOTES_START --> sentinels — so any fix here would just be wiped out by the next benchmark run. The follow-up issue covers preserving the notes block on regeneration.

| Version | Engine | Files | Full Build | No-op | 1-File | Resolve (native) | Resolve (JS) |
|---------|--------|------:|-----------:|------:|-------:|------------------:|-------------:|
| 3.9.6 | native | 744 | 3.0s | 10ms | 54ms | 7ms ~ | 11ms ↑7% |
| 3.9.6 | wasm | 744 | 14.0s | 131ms | 62ms | 7ms ~ | 11ms ↑7% |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Large WASM regressions unannotated in summary table

The WASM engine shows significant regressions vs 3.9.4 (the last version with build data): full build went from 7.6s → 14.0s (~84% slower) and no-op rebuild from 19ms → 131ms (~589% slower). Because 3.9.5 had null build metrics, the generation script produced no / annotations for these columns in the 3.9.6 WASM row, making the regressions invisible to casual readers of the table. It may be worth checking whether the generator should fall back to comparing against the nearest version that has build data when the immediately prior version has nulls.

Fix in Claude Code

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked as a generator improvement: #1043. The blank trend cells are caused by findPrevRelease returning the immediately prior release (3.9.5) which has null build/rebuild metrics, so trend() short-circuits to an empty string. The follow-up issue covers walking further back per-metric to find the nearest release with a non-null value. Worth flagging that the wasm numbers themselves may be partly environmental — the same investigation noted in #1042 about the 3.9.5 SIGKILLs is the right place to assess whether 3.9.6 wasm is a real regression or runner noise.

@carlos-alm
Copy link
Copy Markdown
Contributor

@greptileai

@carlos-alm carlos-alm merged commit bbb2de5 into main May 1, 2026
12 of 13 checks passed
@carlos-alm carlos-alm deleted the benchmark/incremental-v3.9.6-20260430-065206 branch May 1, 2026 08:08
@github-actions github-actions Bot locked and limited conversation to collaborators May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant